qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callo


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices
Date: Wed, 02 Oct 2013 09:08:04 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9

On 10/02/2013 08:20 AM, Peter Lieven wrote:
> if a raw device like an iscsi target or host device is used
> the current implementation makes a second call out to get
> the block status of bs->file. however, the raw driver already
> has called bdrv_get_block_status on bs->file.
> 
> v4: use a flag to detect the raw driver instead of the strncmp
>     hack.

The v4 designation...

> 
> Signed-off-by: Peter Lieven <address@hidden>
> ---

...should appear after the --- separator (useful to reviewers, but
doesn't need to be part of the git history).

>  block.c               |    4 ++--
>  block/raw_bsd.c       |    6 +++++-
>  include/block/block.h |    3 +++
>  3 files changed, 10 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]