[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrapper
From: |
Marcel Apfelbaum |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers |
Date: |
Mon, 07 Oct 2013 11:14:55 +0300 |
> > > static void uhci_reset(void *opaque)
> > > @@ -1240,8 +1239,7 @@ static int usb_uhci_common_initfn(PCIDevice *dev)
> > > /* TODO: reset value should be 0. */
> > > pci_conf[USB_SBRN] = USB_RELEASE_1; // release number
> > >
> > > - s->irq_pin = u->info.irq_pin;
> > > - pci_config_set_interrupt_pin(pci_conf, s->irq_pin + 1);
> > > + pci_config_set_interrupt_pin(pci_conf, u->info.irq_pin + 1);
> >
> > So everyone does this + 1/ - 1 logic.
> >
> > We get comments like:
> > pci_config_set_interrupt_pin(pci_conf, 1); /* interrupt pin 0 */
> > which just shows the API is confusing.
> > How about we change pci_config_set_interrupt_pin to do + 1
> > internally?
> > Then add pci_config_get_interrupt_pin to do - 1.
It seems a good idea.
> >
> > Add a comment that this does not support devices without interrupts,
> > for that - use get_byte directly.
>
>
> Note: this is not a problem with your patch, it can
> be a cleanup on top.
>
I will make another patch(not part of this series)
to be applied on top of this series.
Thanks,
Marcel
- [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 1/8] hw/core: Add interface to allocate and free a single IRQ, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 2/8] hw/pci: add pci wrappers for allocating and asserting irqs, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 3/8] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 4/8] hw/vmxnet3: set interrupts using pci irq wrappers, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 5/8] hw/vfio: set interrupts using pci irq wrappers, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 7/8] hw/pcie: AER and hot-plug events must use device's interrupt, Marcel Apfelbaum, 2013/10/07
- [Qemu-devel] [PATCH v3 8/8] hw/pci: removed irq field from PCIDevice, Marcel Apfelbaum, 2013/10/07
- Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin, Michael S. Tsirkin, 2013/10/07
- Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin, Michael S. Tsirkin, 2013/10/08