[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array |
Date: |
Mon, 07 Oct 2013 12:11:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
On 10/04/2013 07:49 PM, Peter Maydell wrote:
> On 5 October 2013 01:57, Fabien Chouteau <address@hidden> wrote:
> >> @@ -47,7 +48,9 @@
>> #include "hw/xen/xen.h"
>> #include "hw/i386/apic_internal.h"
>> #endif
>> +#include "monitor/monitor_def.h"
>>
>> +extern const MonitorDef i386_monitor_defs[];
>
> Declare this in cpu-qom.h, rather than having an
> extern declaration in a .c file.
>
I didn't manage to do that.
>
>> --- a/target-sparc/cpu-qom.h
>> +++ b/target-sparc/cpu-qom.h
>> @@ -21,7 +21,6 @@
>> #define QEMU_SPARC_CPU_QOM_H
>>
>> #include "qom/cpu.h"
>> -#include "cpu.h"
>
> ...why have you deleted this #include ?
>
I thought I added it myself, that's why I removed it.
--
Fabien Chouteau
- [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v4), Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Andreas Färber, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array,
Fabien Chouteau <=
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
[Qemu-devel] [PATCH 1/4] Fix coding style, Fabien Chouteau, 2013/10/04