[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour for device_del |
Date: |
Tue, 8 Oct 2013 11:44:28 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 01.10.2013 um 19:06 hat Eric Blake geschrieben:
> On 10/01/2013 07:20 AM, Kevin Wolf wrote:
> > Block devices creates with -drive and drive_add should automatically
> > disappear if the guest device is unplugged. blockdev-add ones shouldn't.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > Reviewed-by: Max Reitz <address@hidden>
> > ---
> > tests/qemu-iotests/064 | 133
> > +++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/064.out | 80 +++++++++++++++++++++++
> > tests/qemu-iotests/common.filter | 8 +++
> > tests/qemu-iotests/group | 1 +
> > 4 files changed, 222 insertions(+)
> > create mode 100755 tests/qemu-iotests/064
> > create mode 100644 tests/qemu-iotests/064.out
>
> Reviewed-by: Eric Blake <address@hidden>
>
>
> > +
> > +_supported_fmt qcow2
> > +_supported_proto file
> > +_supported_os Linux
>
> Is this test really Linux-only?
Probably most tests aren't, but all of them have "_supported_os Linux".
If anyone wanted to use this for something, they'd have to make a bigger
change than just to this patch.
Kevin
- Re: [Qemu-devel] [PATCH v2 16/17] blockdev: Don't disable COR automatically with blockdev-add, (continued)
- [Qemu-devel] [PATCH v2 17/17] blockdev: blockdev_init() error conversion, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 08/17] blockdev: Move parsing of 'if' option to drive_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 07/17] blockdev: Move parsing of 'media' option to drive_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour for device_del, Kevin Wolf, 2013/10/01
- Re: [Qemu-devel] [PATCH v2 00/17] blockdev-add QMP command, Eric Blake, 2013/10/01