Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert

[Wenchao Xia]

于 2013/10/1 22:56, Eric Blake 写道:
> On 09/25/2013 06:16 PM, Wenchao Xia wrote:
> > Also renamed snapshot_name to snapshot_id_or_name to tip better.
> s/to tip better/as a better hint of what it does/
>
> > Signed-off-by: Wenchao Xia<address@hidden>
> > ---
> >   qemu-img-cmds.hx |    2 +-
> >   qemu-img.c       |    2 ++
> >   qemu-img.texi    |    7 +++++--
> >   3 files changed, 8 insertions(+), 3 deletions(-)
> Squash this into 5/7.
  OK.

> > +           "  'snapshot_param' is param used for internal snapshot, format 
> > is\n"
> > +           "    'snapshot.id=[ID],snapshot.name=[NAME]'\n"
> Again, can you reuse the existing -s, instead of having to add -L, by
  There may be compatiability issue for existing user, I think add -l 
and deprecate old -s,
would be better.

> making the command line parser smarter about whether it is seeing a
> single name vs. a string starting with 'snapshot.'?