[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 07/39] hw/vmxnet3: set interrupts using pci irq wr
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 07/39] hw/vmxnet3: set interrupts using pci irq wrappers |
Date: |
Tue, 15 Oct 2013 09:30:25 +0300 |
From: Marcel Apfelbaum <address@hidden>
pci_set_irq uses PCI_INTERRUPT_PIN config register
to compute device INTx pin to assert/deassert.
An assert is used to ensure that intx received
from the quest OS corresponds to PCI_INTERRUPT_PIN.
Signed-off-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/net/vmxnet3.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 49c2466..19687aa 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -336,7 +336,7 @@ static bool _vmxnet3_assert_interrupt_line(VMXNET3State *s,
uint32_t int_idx)
}
VMW_IRPRN("Asserting line for interrupt %u", int_idx);
- qemu_set_irq(d->irq[int_idx], 1);
+ pci_irq_assert(d);
return true;
}
@@ -356,7 +356,7 @@ static void _vmxnet3_deassert_interrupt_line(VMXNET3State
*s, int lidx)
assert(!s->msi_used || !msi_enabled(d));
VMW_IRPRN("Deasserting line for interrupt %u", lidx);
- qemu_set_irq(d->irq[lidx], 0);
+ pci_irq_deassert(d);
}
static void vmxnet3_update_interrupt_line_state(VMXNET3State *s, int lidx)
@@ -1299,6 +1299,12 @@ static void vmxnet3_update_features(VMXNET3State *s)
}
}
+static bool vmxnet3_verify_intx(VMXNET3State *s, int intx)
+{
+ return s->msix_used || s->msi_used || (intx ==
+ (pci_get_byte(s->parent_obj.config + PCI_INTERRUPT_PIN) - 1));
+}
+
static void vmxnet3_activate_device(VMXNET3State *s)
{
int i;
@@ -1332,6 +1338,7 @@ static void vmxnet3_activate_device(VMXNET3State *s)
s->event_int_idx =
VMXNET3_READ_DRV_SHARED8(s->drv_shmem, devRead.intrConf.eventIntrIdx);
+ assert(vmxnet3_verify_intx(s, s->event_int_idx));
VMW_CFPRN("Events interrupt line is %u", s->event_int_idx);
s->auto_int_masking =
@@ -1364,6 +1371,7 @@ static void vmxnet3_activate_device(VMXNET3State *s)
/* Read interrupt number for this TX queue */
s->txq_descr[i].intr_idx =
VMXNET3_READ_TX_QUEUE_DESCR8(qdescr_pa, conf.intrIdx);
+ assert(vmxnet3_verify_intx(s, s->txq_descr[i].intr_idx));
VMW_CFPRN("TX Queue %d interrupt: %d", i, s->txq_descr[i].intr_idx);
@@ -1411,6 +1419,7 @@ static void vmxnet3_activate_device(VMXNET3State *s)
/* Read interrupt number for this RX queue */
s->rxq_descr[i].intr_idx =
VMXNET3_READ_TX_QUEUE_DESCR8(qd_pa, conf.intrIdx);
+ assert(vmxnet3_verify_intx(s, s->rxq_descr[i].intr_idx));
VMW_CFPRN("RX Queue %d interrupt: %d", i, s->rxq_descr[i].intr_idx);
--
MST
- [Qemu-devel] [PULL v2 00/39] pci, pc, acpi fixes, enhancements, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 01/39] memory: Change MemoryRegion priorities from unsigned to signed, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 02/39] docs/memory: Explictly state that MemoryRegion priority is signed, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 03/39] hw/pci: partially handle pci master abort, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 04/39] hw/core: Add interface to allocate and free a single IRQ, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 05/39] hw/pci: add pci wrappers for allocating and asserting irqs, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 06/39] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 07/39] hw/vmxnet3: set interrupts using pci irq wrappers,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 08/39] hw/vfio: set interrupts using pci irq wrappers, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 10/39] hw/pcie: AER and hot-plug events must use device's interrupt, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 11/39] hw/pci: removed irq field from PCIDevice, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 09/39] hw: set interrupts using pci irq wrappers, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 12/39] cleanup object.h: include error.h directly, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 13/39] qom: cleanup struct Error references, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 14/39] qom: add pointer to int property helpers, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 15/39] pci: fix up w64 size calculation helper, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 16/39] fw_cfg: interface to trigger callback on read, Michael S. Tsirkin, 2013/10/15
- [Qemu-devel] [PULL v2 17/39] loader: support for unmapped ROM blobs, Michael S. Tsirkin, 2013/10/15