Re: [Qemu-devel] [PATCH] linux-user: create target_structs header to place ipc_perm and shmid_ds

[Andreas Färber]

Hi,

Am 25.10.2013 11:25, schrieb Erik de Castro Lopo:
> Petar Jovanovic wrote:
> 
>> From: Petar Jovanovic <address@hidden>
>>
>> Creating target_structs header in linux-user/$arch/ and making
>> target_ipc_perm and target_shmid_ds its first inhabitants.
>> The struct defintions may/should be further fine-tuned by arch maintainers.
>>
>> Signed-off-by: Petar Jovanovic <address@hidden>
> 
> Reviewed-by: Erik de Castro Lopo <address@hidden>
> 
> 
> I'm relatively new to QEMU and this is my first review. This change
> looks sane to me, applies cleanly and compiles without any new warnings.

What's missing is file headers for the new .h files indicating which
license they are under. The general concept of moving stuff from big .c
to several .h files seems welcome to me.

> In future I will be attempting to review anything in the linux-user
> tree.

Review is always appreciated. :)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg