Re: [Qemu-devel] [PATCH 06/24] ide: simplify set_inactive callbacks

[Kevin Wolf]

Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
> Drop the unused return value and make the callback optional.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/ide/ahci.c     | 8 --------
>  hw/ide/core.c     | 5 +++--
>  hw/ide/internal.h | 2 +-
>  hw/ide/macio.c    | 1 -
>  hw/ide/pci.c      | 4 +---
>  5 files changed, 5 insertions(+), 15 deletions(-)

> @@ -1125,8 +1120,6 @@ static int ahci_async_cmd_done(IDEDMA *dma)
>          ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
>          qemu_bh_schedule(ad->check_bh);
>      }
> -
> -    return 0;
>  }
>  
>  static void ahci_irq_set(void *opaque, int n, int level)

This hunk should be in patch 7.

Kevin