Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

[Michael S. Tsirkin]

On Mon, Nov 04, 2013 at 03:13:50PM +0100, Paolo Bonzini wrote:
> Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto:
> > Disable acpi build for isapc and no_kvmclock machine
> > types (used by xen), since acpi build currently expects pci.
> > 
> > Reported-by: Andreas Färber <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> Wait, Xen is not using pc_init_pci_no_kvmclock.  But that's not a
> problem, we can expose ACPI info via fw_cfg and then Xen hvmloader can
> decide whether to use it or not.  Right now it doesn't, maybe later on
> it should.
> 
> If Xen is broken, we need to patch pc_xen_hvm_init, but Andreas only
> tested isapc not xenfv.  So unless someone reports otherwise, there is
> no need to exclude ACPI info from "-M xenpv".
> 
> So my first review was wrong, but I still agree with the patch.
> 
> Paolo

I really went by the comment
/* PC init function for pc-0.10 to pc-0.13, and reused by xenfv */
static void pc_init_pci_no_kvmclock(QEMUMachineInitArgs *args)

Clearly pc-0.13 and older should not have acpi :)

-- 
MST