[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritan
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritance for struct |
Date: |
Wed, 06 Nov 2013 06:33:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/05/2013 08:20 PM, Wenchao Xia wrote:
>>> + 'server': {
>>> + '_base': 'NetworkConnectionInfo',
>>
>> Interesting idea for shorthand. However, I would suggest that you pick
>> a different character than '_', since '_' is valid in names. That is,
>> we already have special handling of leading '*' to mark a field as
>> optional, so I suggest something like '^' to mark a base class. By
>> using a non-name character, it becomes more obvious that the leading
>> character has a special meaning to the qapi generator.
>>
>> I'm also not convinced yet that we want this shorthand; in particular,
>> I'm worried whether it will make the introspection patches harder to
>> write.
>>
> I am not sure about this approach either, so put RFC tag on it. The
> purpose is allow not to define structures that would be only used once.
>
> What instrospection patch do you mean? Python instrospection
> mechnism? You mean there is a python utility which recognize
> only keyword "base" now?
No, I'm talking about Amos' patches to expose the qapi to the user via a
QMP command. Last version proposed was here:
https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg02494.html
although with the addition of discriminated union types in the meantime,
my understanding is Amos is planning on posting another version soon for
the 1.8 timeframe.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC 04/10] qapi script: code move for generate_enum_name(), (continued)
- [Qemu-devel] [PATCH RFC 04/10] qapi script: code move for generate_enum_name(), Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH RFC 01/10] qapi: fix memleak by add implict struct functions in dealloc visitor, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH RFC 03/10] qapi script: check correctness of discriminator values in union, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH RFC 06/10] qapi script: not generate hidden enum type for pre-defined enum discriminator, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritance for struct, Wenchao Xia, 2013/11/05
[Qemu-devel] [PATCH RFC 08/10] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2013/11/05
[Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test for input visitor, Wenchao Xia, 2013/11/05
[Qemu-devel] [PATCH RFC 10/10] tests: add cases for inherited struct and union with discriminator, Wenchao Xia, 2013/11/05