[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/39] exec: create function to get a single dir
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit |
Date: |
Wed, 06 Nov 2013 16:11:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 3 ++-
> include/exec/memory-internal.h | 6 ++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/exec.c b/exec.c
> index 7cf5634..36b0a66 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1374,9 +1374,10 @@ found:
> static void notdirty_mem_write(void *opaque, hwaddr ram_addr,
> uint64_t val, unsigned size)
> {
> +
> int dirty_flags;
Is this whitespace addition spurious?
...
>
> +static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
> + int dirty_flag)
Indentation off by one.
But whitespace doesn't impact the patch, so you can mark 1 through 6 as:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 02/39] memory: cpu_physical_memory_set_dirty_flags() result is never used, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit, Juan Quintela, 2013/11/06
- Re: [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit,
Eric Blake <=
- [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write(), Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 07/39] memory: make cpu_physical_memory_is_dirty return bool, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 10/39] memory: set single dirty flags when possible, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 09/39] memory: all users of cpu_physical_memory_get_dirty used only one flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag, Juan Quintela, 2013/11/06