[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write() |
Date: |
Wed, 06 Nov 2013 16:12:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> We don't need to make special things for CODE, just set the other two bits
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 36b0a66..27e4540 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1374,12 +1374,8 @@ found:
> static void notdirty_mem_write(void *opaque, hwaddr ram_addr,
> uint64_t val, unsigned size)
> {
> -
> - int dirty_flags;
Huh, you just undid the whitespace addition I called out in 6/39.
For 7 and 8,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h, (continued)
- [Qemu-devel] [PATCH 02/39] memory: cpu_physical_memory_set_dirty_flags() result is never used, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write(), Juan Quintela, 2013/11/06
- Re: [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write(),
Eric Blake <=
- [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 07/39] memory: make cpu_physical_memory_is_dirty return bool, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 10/39] memory: set single dirty flags when possible, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 09/39] memory: all users of cpu_physical_memory_get_dirty used only one flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG, Juan Quintela, 2013/11/06