[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three |
Date: |
Wed, 06 Nov 2013 16:39:52 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/06/2013 06:04 AM, Juan Quintela wrote:
> After all the previous patches, spliting the bitmap gets direct.
>
> ToDo: Why can't i include "exec/memory.h" into cpu-all.h? This is the
> reason that I have duplicated DIRTY_MEMORY_NUM.
>
> ToDo2: current bitmaps have one int as index, this limit us to 8TB RAM
> guest, Should we move to longs?
Do we still want "ToDo" in the commit message?
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 9 ++++++---
> include/exec/cpu-all.h | 4 +++-
> include/exec/memory-internal.h | 11 ++++-------
> 3 files changed, 13 insertions(+), 11 deletions(-)
But the code looks correct. For 14-19,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag, (continued)
- [Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 14/39] memory: use bit 2 for migration, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 15/39] memory: make sure that client is always inside range, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 16/39] memory: only resize dirty bitmap when memory size increases, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 17/39] memory: cpu_physical_memory_clear_dirty_flag() result is never used, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 18/39] bitmap: Add bitmap_zero_extend operation, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three, Juan Quintela, 2013/11/06
- Re: [Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three,
Eric Blake <=
- [Qemu-devel] [PATCH 20/39] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 21/39] memory: unfold cpu_physical_memory_set_dirty() in its only user, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 22/39] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 23/39] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 24/39] memory: cpu_physical_memory_get_dirty() is used as returning a bool, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 26/39] memory: use find_next_bit() to find dirty bits, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 25/39] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 27/39] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations, Juan Quintela, 2013/11/06