Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

[Matthias Brugger]

2013/11/5 Stefan Hajnoczi <address@hidden>:
> On Mon, Nov 04, 2013 at 11:28:41AM +0100, Matthias Brugger wrote:
>> v2:
>>  - fix issues found by checkpatch.pl
>>  - change the descritpion of patch 3
>>
>> This patch series makes the thread pool implementation modular.
>> This allows each drive to use a special implementation.
>> The patch series prepares qemu to be able to include thread pools different 
>> to
>> the one actually implemented. It will allow to implement approaches like
>> paravirtualized block requests [1].
>>
>> [1] 
>> http://www.linux-kvm.org/wiki/images/5/53/2012-forum-Brugger-lightningtalk.pdf
>
> -drive aio=threads|native already distinguishes between different AIO
> implementations.  IMO -drive aio= is the logical interface if you want
> to add a new AIO mechanism.

Good point.

>
> I'd also like to see the thread pool implementation you wish to add
> before we add a layer of indirection which has no users yet.

Fair enough, I will evaluate if it will make more sense to implement a
new AIO infrastructure instead to try reuse the thread-pool.
Actually my implementation will differ in the way, that we will have
several workerthreads with everyone of them having its own queue. The
requests will be distributed between them depending on an identifier.
The request function which  the worker_thread call will be the same as
using aio=threads, so I'm not quite sure which will be the way to go.
Any opinions and hints, like the one you gave are highly appreciated.


-- 
motzblog.wordpress.com