[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/7] exec: pass hw address to phys_page_find
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH v2 4/7] exec: pass hw address to phys_page_find |
Date: |
Wed, 13 Nov 2013 21:23:55 +0200 |
callers always shift by target page bits so let's just do this
internally.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
exec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/exec.c b/exec.c
index ec46aea..edb577f 100644
--- a/exec.c
+++ b/exec.c
@@ -216,10 +216,11 @@ static void phys_page_set(AddressSpaceDispatch *d,
phys_page_set_level(&d->phys_map, &index, &nb, leaf, P_L2_LEVELS - 1);
}
-static MemoryRegionSection *phys_page_find(PhysPageEntry lp, hwaddr index,
+static MemoryRegionSection *phys_page_find(PhysPageEntry lp, hwaddr addr,
Node *nodes, MemoryRegionSection
*sections)
{
PhysPageEntry *p;
+ hwaddr index = addr >> TARGET_PAGE_BITS;
int i;
for (i = P_L2_LEVELS; lp.skip && (i -= lp.skip) >= 0;) {
@@ -245,8 +246,7 @@ static MemoryRegionSection
*address_space_lookup_region(AddressSpaceDispatch *d,
MemoryRegionSection *section;
subpage_t *subpage;
- section = phys_page_find(d->phys_map, addr >> TARGET_PAGE_BITS,
- d->nodes, d->sections);
+ section = phys_page_find(d->phys_map, addr, d->nodes, d->sections);
if (resolve_subpage && section->mr->subpage) {
subpage = container_of(section->mr, subpage_t, iomem);
section = &d->sections[subpage->sub_section[SUBPAGE_IDX(addr)]];
@@ -800,7 +800,7 @@ static void register_subpage(AddressSpaceDispatch *d,
MemoryRegionSection *secti
subpage_t *subpage;
hwaddr base = section->offset_within_address_space
& TARGET_PAGE_MASK;
- MemoryRegionSection *existing = phys_page_find(d->phys_map, base >>
TARGET_PAGE_BITS,
+ MemoryRegionSection *existing = phys_page_find(d->phys_map, base,
next_map.nodes,
next_map.sections);
MemoryRegionSection subsection = {
.offset_within_address_space = base,
--
MST
- [Qemu-devel] [PATCH v2 0/7] making address spaces 64 bit wide, Michael S. Tsirkin, 2013/11/13
- [Qemu-devel] [PATCH v2 1/7] split definitions for exec.c and translate-all.c radix trees, Michael S. Tsirkin, 2013/11/13
- [Qemu-devel] [PATCH v2 2/7] exec: replace leaf with skip, Michael S. Tsirkin, 2013/11/13
- [Qemu-devel] [PATCH v2 3/7] exec: extend skip field to 6 bit, page entry to 32 bit, Michael S. Tsirkin, 2013/11/13
- [Qemu-devel] [PATCH v2 4/7] exec: pass hw address to phys_page_find,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level compression, Michael S. Tsirkin, 2013/11/13
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tr ee page level compression, Avi Kivity, 2013/11/14
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Michael S. Tsirkin, 2013/11/14
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Avi Kivity, 2013/11/14
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Michael S. Tsirkin, 2013/11/14
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Avi Kivity, 2013/11/14
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Michael S. Tsirkin, 2013/11/17
- Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression, Avi Kivity, 2013/11/17
[Qemu-devel] [PATCH v2 6/7] exec: make address spaces 64-bit wide, Michael S. Tsirkin, 2013/11/13
[Qemu-devel] [PATCH v2 7/7] exec: reduce L2_PAGE_SIZE, Michael S. Tsirkin, 2013/11/13