[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list |
Date: |
Wed, 13 Nov 2013 19:03:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/13/2013 06:31 PM, Wenchao Xia wrote:
>
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -948,8 +948,8 @@
>> # @tray_open: #optional True if the device has a tray and it is open
>> # (only present if removable is true)
>> #
>> -# @dirty: #optional dirty bitmap information (only present if the dirty
>> -# bitmap is enabled)
>> +# @dirty-bitmaps: #optional dirty bitmaps information (only present
>> if the
>> +# driver has one or more dirty bitmaps)
>> #
>> # @io-status: #optional @BlockDeviceIoStatus. Only present if the
>> device
>> # supports it and the VM is configured to stop on errors
>> @@ -963,7 +963,7 @@
>> 'data': {'device': 'str', 'type': 'str', 'removable': 'bool',
>> 'locked': 'bool', '*inserted': 'BlockDeviceInfo',
>> '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus',
>> - '*dirty': 'BlockDirtyInfo' } }
>> + '*dirty-bitmaps': ['BlockDirtyInfo'] } }
>>
>> ##
>> # @query-block:
>>
> An old member is removed, is there a compatiable issue for user?
We already answered this; there is no back-compat issue with removing a
variable that is already marked optional and which is used in an
output-only type:
https://lists.gnu.org/archive/html/qemu-devel/2013-11/msg01446.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list, Eric Blake, 2013/11/13
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list, Wenchao Xia, 2013/11/13