Re: [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()

[Vlad Yasevich]

On 11/15/2013 12:06 PM, Vlad Yasevich wrote:
> Save the result of the call to object_get_cannonical_path()
> so we can free it.
>
> Signed-off-by: Vlad Yasevich <address@hidden>
> ---
>   qom/object.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index b617f26..21b6f87 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
>   void object_property_set_link(Object *obj, Object *value,
>                                 const char *name, Error **errp)
>   {
> -    object_property_set_str(obj, object_get_canonical_path(value),
> -                            name, errp);
> +    gchar *path = object_get_cannonical_path(value);
> +    object_property_set_str(obj, path, name, errp);
> +    gfree(path);
>   }
>
>   Object *object_property_get_link(Object *obj, const char *name,

Self-nack.  Forgot to commit the changes that actually make it build and 
work :/

-vlad