[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-s
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options |
|
Date: |
Tue, 19 Nov 2013 08:52:35 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/19/2013 08:37 AM, Kevin Wolf wrote:
> In the case of snapshot=on, don't rely on the backing file path in the
> temporary image any more, but override the backing file with the given
> set of options. This way, block drivers that don't use a file name can
> be accessed with snapshot=on, for example:
>
> -drive file.driver=nbd,file.host=localhost,snapshot=on
>
> Which becomes internally something like:
>
>
> file.filename=/tmp/vl.AWQZCu,backing.file.driver=nbd,backing.file.host=localhost
[libvirt isn't using snapshot=on, but that doesn't affect the utility of
this patch]
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 49 +++++++++++++++++++++++--------------------------
> 1 file changed, 23 insertions(+), 26 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature