[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1 |
Date: |
Wed, 20 Nov 2013 13:02:41 +0100 |
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
> From: Dave Airlie <address@hidden>
>
> This is a virtio-vga device built on top of the virtio-gpu device.
Ah, I see what you use the wrapping for. Hmm. I think you should use a
common base class instead, i.e. something like virtio-gpu-base which
holds all the common stuff. Both virtio-gpu and virtio-vga can use that
as TypeInfo->parent then. This way virtio-vga doesn't have to muck with
virtio-gpu internals. virtio-gpu-base can be tagged as abstract class
(using .abstract = true) so it will not be instantiated directly.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2), (continued)
- [Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display, Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 4/8] console: add ability to wrap a console., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 3/8] console: add information retrival wrappers, Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 5/8] sdl2: update for multihead support., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.1 of the virtio based GPU code., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 7/8] virtio-vga: v1, Dave Airlie, 2013/11/20
- Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 8/8] HACK: just to make things start easier with libvirt, Dave Airlie, 2013/11/20