Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

[Peter Maydell]

On 21 November 2013 09:15, Michael S. Tsirkin <address@hidden> wrote:
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 486e705..97e0fba 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -287,14 +287,17 @@ static inline void build_append_array(GArray *array, 
> GArray *val)
>
>  static void build_append_nameseg(GArray *array, const char *format, ...)
>  {
> -    GString *s = g_string_new("");
> +    /* It would be nicer to use g_string_vprintf but it's only there in 2.22 
> */
> +    char s[] = "XXXX";
> +    int len;
>      va_list args;
>
>      va_start(args, format);
>      g_string_vprintf(s, format, args);
> +    len = vsnprintf(s, sizeof s, format, args);
>      va_end(args);

...this patch doesn't seem to have removed the g_string_vprintf
call?

thanks
-- PMM