[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform |
Date: |
Fri, 22 Nov 2013 10:24:06 -0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 22, 2013 at 06:17:51PM +0000, Peter Maydell wrote:
> On 22 November 2013 18:11, Christoffer Dall <address@hidden> wrote:
> > On Fri, Nov 22, 2013 at 05:17:14PM +0000, Peter Maydell wrote:
> >> + * Emulate a virtual board which works by passing Linux all the
> >> information
> >> + * it needs about what devices are present via the device tree.
> >> + * There are some restrictions about what we can do here:
> >> + * + we can only present devices whose Linux drivers will work based
> >> + * purely on the device tree with no platform data at all
> >> + * + we want to present a very stripped-down minimalist platform,
> >> + * both because this reduces the security attack surface from the guest
> >> + * and also because it reduces our exposure to being broken when
> >> + * the kernel updates its device tree bindings and requires further
> >> + * information in a device binding that we aren't providing.
> >> + * This is essentially the same approach kvmtool uses.
> >
> > nit: questionable value of this last line in the comment.
>
> Well, it says we're not doing something completely bonkers
> of our own devising ;-)
>
;)
> > + vbi->bootinfo.board_id = -1;
> >
> > board_id = -1 ?
>
> This is what the kernel's boot protocol says you should
> pass as the board ID register for boards which are new
> enough that they only support booting via device tree
> and not the old-style board ID number system.
>
ok, thanks.
-Christoffer
- [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code, (continued)
- [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 05/11] target-arm: Add ARMCPU field for Linux device-tree 'compatible' string, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 01/11] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 11/11] hw/arm/virt: Support -cpu host, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 08/11] linux-headers: Update from mainline, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 06/11] target-arm: Allow secondary KVM CPUs to be booted via PSCI, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform, Peter Maydell, 2013/11/22
- Re: [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support, Christoffer Dall, 2013/11/22