Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

[Fam Zheng]

On Tue, Nov 26, 2013 at 5:22 PM, Paolo Bonzini <address@hidden> wrote:
> Il 26/11/2013 03:07, Fam Zheng ha scritto:
>>>>
>>>> +void bdrv_op_unblock(BlockDriverState *bs, BlockOpType op, Error
>>>> *reason)
>>>
>>> What about making BlockOpType a bitmask, and having bdrv_op_{,un}block
>>> take multiple ORed BlockOpTypes?
>>>
>>> bdrv_op_{,un}block_all then are not necessary, you only need a
>>> BLOCK_OPERATION_ALL value.
>>>
>>
>> Bitmap is not enough, at least it should be an array. For example when
>> we enable multiple block jobs, there're two stoppers for drive_del, right?
>
> I said bitmask, not bitmap. :)
>

OK. Sorry..

> So that you can add the same Error to multiple items of the array with a
> single bdrv_op_block call (by ORing them into the second parameter).
>

What data type to contain this? I'm not sure 64 is enough in long term...

Fam