[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests |
Date: |
Thu, 28 Nov 2013 22:34:16 +0800 |
On Thu, Nov 28, 2013 at 7:56 PM, Kevin Wolf <address@hidden> wrote:
> Am 27.11.2013 um 03:01 hat Fam Zheng geschrieben:
>> On 2013年11月20日 10:25, Fam Zheng wrote:
>> >The second patch is too large as a mail, you can pull from:
>> >
>> > https://github.com/famz/qemu.git 035-filter-qemu-io
>> >
>> >v2: Rebase to current master.
>> > [01] Add Reviewed-by for Eric.
>> > [02] Update comment to describe the command for mechanical
>> > substitution. (Eric)
>>
>> Kevin, would you like to take this one?
>
> I would, but this way it simply doesn't work.
>
> The '035-filter-qemu-io' branch in your repo is something, but certainly
> not this series. It may be some early RFC where you only fixed one case.
> I then found the 'iotests-filter-qemu-io' (which is already not what you
> said) branch and I almost would have applied it, but I noticed it's not
> exactly the same as this series; I suppose it's version 1.
>
> Eric reviewed _something_, but the two branches I found aren't what you
> sent, and he didn't specify the commit ID he reviewed, so I can't put
> his Reviewed-by tag anywhere, because I simply don't know what he looked
> at.
>
> Fam, can you push the _current_ version somewhere and tell me the
> correct branch name and commit ID? Eric, can you then tell me if this
> newly pushed code matches what you reviewed?
Sorry, I've pushed again to:
https://github.com/famz/qemu.git for-kevin
Please fetch again.
Fam