[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize |
Date: |
Fri, 29 Nov 2013 17:08:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 29.11.2013 11:17, schrieb Paolo Bonzini:
> diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c
> index 33a8ea4..ba7f9cc 100644
> --- a/tests/qdev-monitor-test.c
> +++ b/tests/qdev-monitor-test.c
> @@ -32,10 +32,8 @@ static void test_device_add(void)
> "}}");
> g_assert(response);
> error = qdict_get_qdict(response, "error");
> - g_assert(!strcmp(qdict_get_try_str(error, "class") ?: "",
> - "GenericError"));
> g_assert(!strcmp(qdict_get_try_str(error, "desc") ?: "",
> - "Device initialization failed."));
> + "Device needs media, but drive is empty"));
> QDECREF(response);
>
> /* Delete the drive */
Thanks for finding and fixing this qtest failure!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 14/30] virtio-9p: QOM realize preparations, (continued)
- [Qemu-devel] [PATCH 14/30] virtio-9p: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 15/30] virtio-blk: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 16/30] virtio-serial: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 17/30] virtio-net: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 18/30] virtio-balloon: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 19/30] virtio-rng: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 20/30] virtio-scsi: QOM realize preparations, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 21/30] virtio: Start converting VirtioDevice to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 22/30] virtio-9p: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize,
Andreas Färber <=
- [Qemu-devel] [PATCH 24/30] virtio-serial: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 25/30] virtio-net: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 26/30] virtio-balloon: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 27/30] virtio-rng: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 28/30] virtio-scsi: Convert to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 29/30] virtio: Complete converting VirtioDevice to QOM realize, Paolo Bonzini, 2013/11/29
- [Qemu-devel] [PATCH 30/30] virtio: Convert exit to unrealize, Paolo Bonzini, 2013/11/29