qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support
Date: Thu, 5 Dec 2013 11:46:34 +1000

Hi Liguang,

V9 has some checkpatch errors:

address@hidden qemu]$ git format-patch HEAD~5
0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch
0002-hw-timer-add-allwinner-a10-timer.patch
0003-hw-intc-add-allwinner-A10-interrupt-controller.patch
0004-hw-arm-add-allwinner-a10-SoC-support.patch
0005-hw-arm-add-cubieboard-support.patch
address@hidden qemu]$ ./scripts/checkpatch.pl 00*
ERROR: need consistent spacing around '*' (ctx:WxB)
#30: FILE: include/migration/vmstate.h:618:
+    VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_ptimer,
ptimer_state *)
                                                                               ^

total: 1 errors, 0 warnings, 59 lines checked

0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch has style problems, please
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
WARNING: line over 80 characters
#75: FILE: hw/timer/allwinner-a10-pit.c:33:
+    case AW_A10_PIT_TIMER_BASE ... AW_A10_PIT_TIMER_BASE * 6 +
AW_A10_PIT_TIMER_COUNT:

WARNING: line over 80 characters
#124: FILE: hw/timer/allwinner-a10-pit.c:82:
+    case AW_A10_PIT_TIMER_BASE ... AW_A10_PIT_TIMER_BASE * 6 +
AW_A10_PIT_TIMER_COUNT:

total: 0 errors, 2 warnings, 320 lines checked

0002-hw-timer-add-allwinner-a10-timer.patch has style problems, please
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 266 lines checked

0003-hw-intc-add-allwinner-A10-interrupt-controller.patch has no
obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 130 lines checked

0004-hw-arm-add-allwinner-a10-SoC-support.patch has no obvious style
problems and is ready for submission.
total: 0 errors, 0 warnings, 58 lines checked

0005-hw-arm-add-cubieboard-support.patch has no obvious style problems
and is ready for submission.

Please include checkpatch in your pre-send checklist for each version.

I'm still looking trough the series though (now that I have it am'ed
locally), so don't respin on me just yet!

Regards,
Peter

On Thu, Dec 5, 2013 at 10:51 AM, liguang <address@hidden> wrote:
>
> lay a foundation for allwinner A10 SoC with a cortex-a8
> processor, and will add more devices later.
>
> v2: split timer and interrupt controller emulation into
>         their corresponding files.
>
> v3:
> 1. change loader_start address
> 2. add 64-bit counter
> 3. fixup fail to clear interrup status issue
>
> v4:
> 1. add VMSD
> 2. use defines of magic number for readability
> 3. code cleanup
>
> v5:
> 1. add VMSTATE_PTIMER_ARRAY
> 2. code cleanup
>
> v6:
> 1. fix a fiq lost issue pointed out by Peter Crosthwaite
> 2. code cleanup
>
> v7:
> model allwinner A10 as a SoC device,
> and add cubieboard.
>
> v8:
> 1. A10 be QOMified as a device
> 2. add AW as prefix of A10
>
> v9:
> code cleanup for PATCH 4/5 A10 SoC support
>
>
> TODO:
> 1. add BROM support
> 2. add more devices
>
> test:
> can boot-up officially released linux kernel build with
> PLL disabled.
> can find test zImage url at:
> http://dl.dbank.com/c0jaibr54s
>
> reference:
> http://linux-sunxi.org/Main_Page
>
>
> Li Guang (5)
>          vmstate: add VMSTATE_PTIMER_ARRAY
>          hw/timer: add allwinner a10 timer
>          hw/intc: add allwinner A10 interrupt controller
>          hw/arm: add allwinner a10 SoC support
>          hw/arm: add cubieboard support
>
> default-configs/arm-softmmu.mak      |   2 +
> hw/arm/Makefile.objs                 |   4 +-
> hw/arm/allwinner-a10.c               |  39 
> +++++++++++++++++++++++++++++++++++++++
> hw/arm/cubieboard.c                  |  33 +++++++++++++++++++++++++++++++++
> hw/intc/Makefile.objs                |   1 +
> hw/intc/allwinner-a10_pic.c          | 218 +++++++++++++++++++++++++++++++++++
> hw/timer/Makefile.objs               |   2 +
> hw/timer/allwinner-a10_pit.c         | 253 ++++++++++++++++++++++++++++++++++
> include/hw/arm/allwinner-a10.h       |  27 +++++++++++++++++++++++++++
> include/hw/intc/allwinner-a10_pic.h  |  40 +++++++
> include/hw/timer/allwinner-a10_pit.h |  57 ++++++++
> include/migration/vmstate.h          |   4 ++++
> savevm.c                             |  31 +++++++++++++++++++++++++++++++
> 13 files changed, 709 insertions(+), 2 deletions(-)
>  create mode 100644 hw/timer/allwinner-a10_pit.c
>  create mode 100644 include/hw/timer/allwinner-a10_pit.h
>  create mode 100644 hw/intc/allwinner-a10_pic.c
>  create mode 100644 include/hw/intc/allwinner-a10_pic.h
>  create mode 100644 hw/arm/allwinner-a10.c
>  create mode 100644 include/hw/arm/allwinner-a10.h
>  create mode 100644 hw/arm/cubieboard.c
>
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]