Re: [Qemu-devel] [PATCH 1/9] target-arm: A64: add support for stp (store pair)

[Alex Bennée]

address@hidden writes:

> On 12/09/2013 10:12 AM, Peter Maydell wrote:
<snip>
>> +    if (wback) {
>> +        if (postindex) {
>> +            tcg_gen_addi_i64(tcg_addr, tcg_addr, offset - (1 << size));
>> +        } else {
>> +            tcg_gen_subi_i64(tcg_addr, tcg_addr, 1 << size);
>> +        }
>
> Perhaps better as
>
>     tcg_gen_addi_i64(tcg_addr, tcg_addr,
>                      (postindex ? offset : 0) - (1 << size));

I'm not so sure it's easier to follow despite my general proclivity for
ternary operator.

>
>
> ?
>
>
> r~

-- 
Alex Bennée
QEMU/KVM Hacker for Linaro