Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

[Tom Musta]

On 12/9/2013 6:01 PM, Richard Henderson wrote:
> On 12/09/2013 07:46 AM, Tom Musta wrote:
>> +    for (i = 0; i < 8; i++) {
>> +        int index = (rs & (0xFFul) << (i*8)) >> (i*8);
> 
> This is a silly expression.  Better as
> 
>     int index = (rs >> (i * 8)) & 0xff;
> 
>> +                ra |= (1<<i);
> 
> Unnecessary parens, and missing spaces around the operator.


Thanks, as always, for reviewing.  I concur with most of the comments ...
will respond only to those that I either disagree with or have further
questions.