[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa memory
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Tue, 10 Dec 2013 17:01:02 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Dec 10, 2013 at 07:03:50PM +0100, Paolo Bonzini wrote:
> Il 10/12/2013 14:15, Eduardo Habkost ha scritto:
> >> > If the total number of the assigned numa nodes memory is not
> >> > equal to the assigned ram size, it will write the wrong data
> >> > to ACPI talb, then the guest will ignore the wrong ACPI table
> >> > and recognize all memory to one node. It's buggy, we should
> >> > check it to ensure that we write the right data to ACPI table.
> >> >
> >> > Signed-off-by: Wanlong Gao <address@hidden>
> > This will make configurations that could be running for years (except
> > that the guest OS was ignoring the NUMA data) suddenly stop running. I
> > just want to confirm: we really want that, right?
> >
> > Does libvirt allow this kind of broken configuration to be generated, or
> > it already ensures the total NUMA node sizes match RAM size?
>
> It allows this. It just converts the <numa> XML to "-numa node".
In that case, if we apply this patch we may want to make libvirt
validate the NUMA configuration instead of getting a cryptic "QEMU
aborted" error message with the actual problem buried in a log file.
(Well, even if we do not apply this patch, I believe it is a good idea to
make libvirt validate the NUMA configuration.)
--
Eduardo
[Qemu-devel] [PATCH V17 01/11] NUMA: move numa related code to new file numa.c, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 06/11] NUMA: add "-numa mem," options, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 04/11] NUMA: convert -numa option to use OptsVisitor, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 03/11] NUMA: Add numa_info structure to contain numa nodes info, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 08/11] NUMA: parse guest numa nodes memory policy, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 05/11] NUMA: introduce NumaMemOptions, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 07/11] NUMA: expand MAX_NODES from 64 to 128, Wanlong Gao, 2013/12/04
[Qemu-devel] [PATCH V17 10/11] NUMA: add qmp command query-numa, Wanlong Gao, 2013/12/04