qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to genera


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string
Date: Wed, 11 Dec 2013 21:26:05 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 12/10/2013 10:48 PM, Wenchao Xia wrote:
> Prior to this patch, qapi-visit.py used custom code to generate enum
> names used for handling a qapi union. Fix it to instead reuse common
> code, with identical generated results, and allowing future updates to
> generation to only need to touch one place.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  scripts/qapi-types.py |    6 +++---
>  scripts/qapi-visit.py |   21 +++++++++++++++------
>  scripts/qapi.py       |   15 +++++++++++----
>  3 files changed, 29 insertions(+), 13 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]