[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to genera
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string |
Date: |
Wed, 11 Dec 2013 21:26:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/10/2013 10:48 PM, Wenchao Xia wrote:
> Prior to this patch, qapi-visit.py used custom code to generate enum
> names used for handling a qapi union. Fix it to instead reuse common
> code, with identical generated results, and allowing future updates to
> generation to only need to touch one place.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> scripts/qapi-types.py | 6 +++---
> scripts/qapi-visit.py | 21 +++++++++++++++------
> scripts/qapi.py | 15 +++++++++++----
> 3 files changed, 29 insertions(+), 13 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V4 0/9] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 2/9] qapi script: add check for duplicated key, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string, Wenchao Xia, 2013/12/11
- Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string,
Eric Blake <=
- [Qemu-devel] [PATCH V4 1/9] qapi script: remember enum values, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 4/9] qapi script: code move for generate_enum_name(), Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 9/9] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 7/9] tests: add cases for inherited struct and union with discriminator, Wenchao Xia, 2013/12/11