qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file conf


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration
Date: Fri, 13 Dec 2013 21:36:50 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> Introduce the "image" option as an alternative to specifying the image
> through the filename.
> 
> Signed-off-by: Max Reitz <address@hidden>

One thing I'd like to see, either in the next version or in a follow-up
series, is to generalise open_image() into a block.c function.

The main difference between blkdebug and blkverify seems to be that
blkverify does image format probing on its main image. This can be a
bool argument to open_image().

Reviewed-by: Kevin Wolf <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]