Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes

[Pantelis Koukousoulas]

Either version is fine with me :)

On Mon, Dec 16, 2013 at 4:27 PM, Gerd Hoffmann <address@hidden> wrote:

  Hi,

> I thought that for lines that are just a logical or of constants
> it would be ok to go over 80 columns, since the alternatives
>
> (shortening the names of constants or breaking the line)
>
> are a little less readable.

I don't find the broken lines unreadable, especially if
you align the stuff nicely like you did ...


> ... and broke the two lines

> that were still longer than 80 columns,

... here.

But if you prefer it this way with the shorter constants, no problem,
I'll happily take it as-is.

cheers,
  Gerd