qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, a


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation
Date: Wed, 18 Dec 2013 14:52:39 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 17, 2013 at 05:33:37AM -0500, Jeff Cody wrote:
> If there is a dirty log file to be replayed in a VHDX image, it is
> replayed in .vhdx_open().  However, if the file is opened read-only,
> then a somewhat cryptic error message results.
> 
> This adds a more helpful error message for the user.  If an image file
> contains a log to be replayed, and is opened read-only, the user is
> instructed to run 'qemu-img check -r all' on the image file.
> 
> Running qemu-img check -r all will cause the image file to be opened
> r/w, which will replay the log file.  If a log file replay is detected,
> this is flagged, and bdrv_check will increase the corruptions_fixed
> count for the image.
> 
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>  block/vhdx-log.c | 12 +++++++++++-
>  block/vhdx.c     | 22 ++++++++++++++++++++--
>  block/vhdx.h     |  5 ++++-
>  3 files changed, 35 insertions(+), 4 deletions(-)

Merged "to be replayed" typo fix when applying the patch.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]