Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns

[Peter Maydell]

On 19 December 2013 21:26, Richard Henderson <address@hidden> wrote:
> On 12/19/2013 01:23 PM, Peter Maydell wrote:
>> Hmm. I clearly don't entirely understand the rules here.
>> The TCG README says "temporaries are only live
>> in a basic block" and "After the end of a basic block, the
>> content of temporaries is destroyed", which I took to
>> mean that the value in the temp was dead after the
>> branch, but that I could freely reuse it for something
>> else afterwards as long as I wrote a new value to
>> it (as we're doing here). I guess that's wrong?
>
> You need to re-allocate it in each basic block.
>
> We don't have enough tcg checking to find errors like this.

We could probably at least update the README to
not be misleading :-)

thanks
-- PMM