Re: [Qemu-devel] [PATCH 09/22] softfloat: Fix float64_to_uint32

[Richard Henderson]

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> From: Tom Musta <address@hidden>
> 
> The float64_to_uint32 has several flaws:
> 
>  - for numbers between 2**32 and 2**64, the inexact exception flag
>    may get incorrectly set.  In this case, only the invalid flag
>    should be set.
> 
>        test pattern: 425F81378DC0CD1F / 0x1.f81378dc0cd1fp+38
> 
>  - for numbers between 2**63 and 2**64, incorrect results may
>    be produced:
> 
>        test pattern: 43EAAF73F1F0B8BD / 0x1.aaf73f1f0b8bdp+63
> 
> This patch re-implements float64_to_uint32 to re-use the
> float64_to_uint64 routine (instead of float64_to_int64).  For the
> saturation case, we ignore any flags which the conversion routine
> has set and raise only the invalid flag.
> 
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
> 
> Signed-off-by: Tom Musta <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  fpu/softfloat.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~