[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_err
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error |
Date: |
Wed, 01 Jan 2014 14:56:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Am 27.12.2013 23:07, schrieb Michael Tokarev:
> From: Stefan Weil <address@hidden>
>
> hw_error is already used for target-arm and target-s390x.
> Using it for target-m68k fixes this compiler warning with Darwin because
> hw_error is declared with QEMU_NORETURN:
>
> target-m68k/translate.c:671:13: warning:
> variable 'offset' is used uninitialized whenever switch default is taken
> [-Wsometimes-uninitialized]
>
> Signed-off-by: Stefan Weil <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
> target-m68k/translate.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
>
Hi,
I'm sorry that I have to revoke this patch.
hw_error is not available for user mode, so this patch fixes Darwin
(which only provides system emulation), but it breaks linking of
m68k-linux-user on Linux hosts.
target-arm and target-s390x use hw_error in conditional code which is
not compiled for user emulation, so they don't have this problem.
Regards
Stefan
- Re: [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error,
Stefan Weil <=