[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader |
Date: |
Mon, 6 Jan 2014 14:00:58 +1000 |
On Mon, Jan 6, 2014 at 1:55 PM, Li Guang <address@hidden> wrote:
> Li Guang wrote:
>>
>> Paolo Bonzini wrote:
>>>
>>> Il 02/01/2014 11:51, Peter Crosthwaite ha scritto:
>>>>>>
>>>>>> No, please use "realize" and avoid init. This way you can use an
>>>>>> Error*
>>>>>> to report the error.
>>>>>>
>>>>>> Also, the actual load_image_targphys call probably should be done in a
>>>>>> reset handler, not at realize time.
>>>>>>
>>>> Ok I think that settles it. The actual blobbing needs to happen at
>>>> reset time. Perhaps the correct approach is to do as much as possible
>>>> (file-path / address sanitsation etc) at realize time, then only the
>>>> actual blob load happens at reset. Going on what Paolo said, I think
>>>> for this device ::init is actually a nop.
>>>
>>> Yeah, also because init is in fact a legacy interface to realize.
>>>
>>> Paolo
>>>
>> Ok, thanks!
>>
>>
> Sorry, seems load blob at reset handler can't do the right job,
> while the same action can play very well at init or realize.
What's the exact problem with the reset idea?
Regards,
Peter
> any suggestion to figure out this problem?
>
> Thanks!
>
>
>
- [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Peter Crosthwaite, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Paolo Bonzini, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Peter Crosthwaite, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Paolo Bonzini, 2014/01/02
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/05
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/05
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader,
Peter Crosthwaite <=
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/05
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Peter Crosthwaite, 2014/01/05
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/05
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/06
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Peter Crosthwaite, 2014/01/06
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Li Guang, 2014/01/06
- Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Paolo Bonzini, 2014/01/06
Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader, Peter Maydell, 2014/01/06