[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64 |
Date: |
Mon, 06 Jan 2014 10:23:45 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/06/2014 05:11 AM, Peter Maydell wrote:
> From: Tom Musta <address@hidden>
>
> The comment preceding the float64_to_uint64 routine suggests that
> the implementation is broken. And this is, indeed, the case.
>
> This patch properly implements the conversion of a 64-bit floating
> point number to an unsigned, 64 bit integer.
>
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
>
> Signed-off-by: Tom Musta <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> fpu/softfloat.c | 101
> +++++++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 93 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 16/24] softfloat: Add support for ties-away rounding, (continued)
- [Qemu-devel] [PATCH v2 16/24] softfloat: Add support for ties-away rounding, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 10/24] softfloat: Fix float64_to_uint32, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 12/24] softfloat: Provide complete set of accessors for fp state, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 03/24] softfloat: Add 16 bit integer to float conversions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 09/24] softfloat: Fix float64_to_uint64_round_to_zero, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 11/24] softfloat: Fix float64_to_uint32_round_to_zero, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 18/24] target-arm: Rename A32 VFP conversion helpers, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64, Peter Maydell, 2014/01/06
- Re: [Qemu-devel] [PATCH v2 05/24] softfloat: Fix float64_to_uint64,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 08/24] softfloat: Add float32_to_uint64(), Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 13/24] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 21/24] target-arm: A64: Add "Floating-point<->fixed-point" instructions, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 19/24] target-arm: Ignore most exceptions from scalbn when doing fixpoint conversion, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 24/24] target-arm: A64: Add support for FCVT between half, single and double, Peter Maydell, 2014/01/06
- [Qemu-devel] [PATCH v2 14/24] softfloat: Add float16 <=> float64 conversion functions, Peter Maydell, 2014/01/06