[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema |
|
Date: |
Mon, 6 Jan 2014 18:18:09 -0500 |
On Fri, 3 Jan 2014 07:10:29 +0800
Wenchao Xia <address@hidden> wrote:
> This series add support for tag/keyword 'event' in qapi-schema.
> A new file was created to store some helper functions in patch 2, patch 4 is
> the test case, patch 5 is a convert example.
>
> The implemention is done by generate API and a batch of parameters for each
> event define, it doesn't generate a struture and visit function in the
> background for every event, so it doesn't support nested structure in the
> define to avoid trouble. A callback layer is added to control the behavior.
> More detail can be found in patch 3's message and incode comments.
The general approach seems good to me. Would be nice to get another
reviewer though, maybe Eric and/or Michael.