[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 38/49] target-i386: Tidy addr16 code in gen_lea_modrm
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 38/49] target-i386: Tidy addr16 code in gen_lea_modrm |
Date: |
Tue, 7 Jan 2014 13:00:28 -0800 |
Unlike the addr32, there was no bug. But we can use the same
technique to reduce the number of TCG ops.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 34 ++++++++++++++++------------------
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 9f38adf..8673f95 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2028,51 +2028,49 @@ static void gen_lea_modrm(CPUX86State *env,
DisasContext *s, int modrm)
break;
default:
case 2:
- disp = cpu_lduw_code(env, s->pc);
+ disp = (int16_t)cpu_lduw_code(env, s->pc);
s->pc += 2;
break;
}
- switch(rm) {
+
+ sum = cpu_A0;
+ switch (rm) {
case 0:
- gen_op_movl_A0_reg(R_EBX);
- gen_op_addl_A0_reg_sN(0, R_ESI);
+ tcg_gen_add_tl(cpu_A0, cpu_regs[R_EBX], cpu_regs[R_ESI]);
break;
case 1:
- gen_op_movl_A0_reg(R_EBX);
- gen_op_addl_A0_reg_sN(0, R_EDI);
+ tcg_gen_add_tl(cpu_A0, cpu_regs[R_EBX], cpu_regs[R_EDI]);
break;
case 2:
- gen_op_movl_A0_reg(R_EBP);
- gen_op_addl_A0_reg_sN(0, R_ESI);
+ tcg_gen_add_tl(cpu_A0, cpu_regs[R_EBP], cpu_regs[R_ESI]);
break;
case 3:
- gen_op_movl_A0_reg(R_EBP);
- gen_op_addl_A0_reg_sN(0, R_EDI);
+ tcg_gen_add_tl(cpu_A0, cpu_regs[R_EBP], cpu_regs[R_EDI]);
break;
case 4:
- gen_op_movl_A0_reg(R_ESI);
+ sum = cpu_regs[R_ESI];
break;
case 5:
- gen_op_movl_A0_reg(R_EDI);
+ sum = cpu_regs[R_EDI];
break;
case 6:
- gen_op_movl_A0_reg(R_EBP);
+ sum = cpu_regs[R_EBP];
break;
default:
case 7:
- gen_op_movl_A0_reg(R_EBX);
+ sum = cpu_regs[R_EBX];
break;
}
- if (disp != 0)
- gen_op_addl_A0_im(disp);
+ tcg_gen_addi_tl(cpu_A0, sum, disp);
tcg_gen_ext16u_tl(cpu_A0, cpu_A0);
no_rm:
if (must_add_seg) {
if (override < 0) {
- if (rm == 2 || rm == 3 || rm == 6)
+ if (rm == 2 || rm == 3 || rm == 6) {
override = R_SS;
- else
+ } else {
override = R_DS;
+ }
}
gen_op_addl_A0_seg(s, override);
}
--
1.8.4.2
- [Qemu-devel] [PULL 26/49] target-i386: Remove gen_op_mov*_A0_im, (continued)
- [Qemu-devel] [PULL 26/49] target-i386: Remove gen_op_mov*_A0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 28/49] target-i386: Remove gen_op_andl_T0_ffff, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 30/49] target-i386: Remove gen_op_movl_T0_T1, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 29/49] target-i386: Remove gen_op_andl_T0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 31/49] target-i386: Remove gen_op_andl_A0_ffff, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 32/49] target-i386: Use TCGMemOp for 'ot' variables, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 33/49] target-i386: Change gen_op_add_reg_* size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 34/49] target-i386: Change gen_op_j*z_ecx size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 35/49] target-i386: Change aflag to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 36/49] target-i386: Change gen_op_mov_reg_A0 size parameter to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 38/49] target-i386: Tidy addr16 code in gen_lea_modrm,
Richard Henderson <=
- [Qemu-devel] [PULL 37/49] target-i386: Change dflag to TCGMemOp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 39/49] target-i386: Combine gen_push_T* into gen_push_v, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 40/49] target_i386: Clean up gen_pop_T0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 44/49] target-i386: Remove gen_op_addl_T0_T1, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 45/49] target-i386: Remove gen_op_mov_TN_reg, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 46/49] target-i386: Remove gen_op_mov_reg_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 47/49] target-i386: Tidy some size computation, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 48/49] target-i386: Rename gen_op_jmp_T0 to gen_op_jmp_v, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 49/49] target-i386: Tidy ljmp, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 42/49] target-i386: Remove gen_op_mov_reg_T0, Richard Henderson, 2014/01/07