[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in q
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests |
Date: |
Wed, 8 Jan 2014 12:33:49 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote:
>
>
> On 06/01/2014 03:23, Stefan Hajnoczi wrote:
> > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote:
> >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> >> index 28ba0d9..af66bbd 100644
> >> --- a/tests/qemu-iotests/common.rc
> >> +++ b/tests/qemu-iotests/common.rc
> >> @@ -189,7 +189,11 @@ _cleanup_test_img()
> >> ;;
> >>
> >> rbd)
> >> - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
> >
> > stderr will be displayed. Why isn't this enough?
> >
>
> Because the progress of the removal operation will be displayed on stderr.
> rbd outputs on stderr even when there is no error.
Is that a bug in the rbd tool which should be fixed? Either by printing
progress to stdout or by adding a --quiet option?