[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] target-arm: A64: Add SIMD EXT
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 04/10] target-arm: A64: Add SIMD EXT |
Date: |
Fri, 10 Jan 2014 11:13:38 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/10/2014 09:12 AM, Peter Maydell wrote:
> + if (pos < 64) {
> + tcg_resl = do_ext64(s, rn, 1, rn, 0, pos);
> + tcg_resh = do_ext64(s, rm, 0, rn, 1, pos);
> + } else {
> + tcg_resl = do_ext64(s, rm, 0, rn, 1, pos - 64);
> + tcg_resh = do_ext64(s, rm, 1, rm, 0, pos - 64);
> + }
Perhaps better to pre-load the values before do_ext64?
In the first case you're loading rn[1] twice, and in the second rm[0] twice.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 10/10] target-arm: A64: Add SIMD scalar copy instructions, (continued)
- [Qemu-devel] [PATCH 02/10] target-arm: A64: Add SIMD ld/st single, Peter Maydell, 2014/01/10
- [Qemu-devel] [PATCH 09/10] target-arm: A64: Add SIMD modified immediate group, Peter Maydell, 2014/01/10
- [Qemu-devel] [PATCH 05/10] target-arm: A64: Add SIMD TBL/TBLX, Peter Maydell, 2014/01/10
- [Qemu-devel] [PATCH 04/10] target-arm: A64: Add SIMD EXT, Peter Maydell, 2014/01/10
- Re: [Qemu-devel] [PATCH 04/10] target-arm: A64: Add SIMD EXT,
Richard Henderson <=
- [Qemu-devel] [PATCH 03/10] target-arm: A64: Add decode skeleton for SIMD data processing insns, Peter Maydell, 2014/01/10
- [Qemu-devel] [PATCH 07/10] target-arm: A64: Add SIMD across-lanes instructions, Peter Maydell, 2014/01/10
- [Qemu-devel] [PATCH 01/10] target-arm: A64: Add SIMD ld/st multiple, Peter Maydell, 2014/01/10