qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device


From: Alexey Kardashevskiy
Subject: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device
Date: Mon, 13 Jan 2014 20:29:09 +1100

Recent changes introduced cannot_instantiate_with_device_add_yet
and removed capability of adding yet another PCI host bridge via
command line for SPAPR platform (POWERPC64 server).

This brings the capability back and puts SPAPR PHB into "bridge"
category.

This is not much use for emulated PHB but it is absolutely required
for VFIO as we put an IOMMU group onto a separate PHB on SPAPR.

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Alexey Kardashevskiy <address@hidden>
---

Are -device and device_add considered synonims? SPAPR PHB can be added
via the command line just fine but cannot from device_add as
"Bus 'main-system-bus' does not support hotplugging".
---
 hw/ppc/spapr_pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index ec00300..66ddf10 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -728,6 +728,8 @@ static void spapr_phb_class_init(ObjectClass *klass, void 
*data)
     dc->props = spapr_phb_properties;
     dc->reset = spapr_phb_reset;
     dc->vmsd = &vmstate_spapr_pci;
+    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
+    dc->cannot_instantiate_with_device_add_yet = false;
 }
 
 static const TypeInfo spapr_phb_info = {
-- 
1.8.4.rc4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]