[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qem
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf |
Date: |
Mon, 13 Jan 2014 17:03:11 +0200 |
On Mon, Jan 13, 2014 at 03:56:49PM +0100, Paolo Bonzini wrote:
> Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto:
> >
> > if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) {
> > printk(KERN_ERR "virtio_pci: expected ABI version %d,
> > got %d\n",
> > VIRTIO_PCI_ABI_VERSION, pci_dev->revision);
> > return -ENODEV;
> > }
> >
> > so it seems better to be consistent.
> > in any case, we must check subsystem ids, the spec is very
> > explicit on this point.
>
> This is not a virtio device.
>
> Paolo
oh
I didn't realize that - thought it's virtio serial we are talking about.
In that case I agree with Gerd.
- [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Miki Mishael, 2014/01/05
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Paolo Bonzini, 2014/01/07
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Yan Vugenfirer, 2014/01/08
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Paolo Bonzini, 2014/01/08
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Michael S. Tsirkin, 2014/01/08
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Gerd Hoffmann, 2014/01/13
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Michael S. Tsirkin, 2014/01/13
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Paolo Bonzini, 2014/01/13
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf, Paolo Bonzini, 2014/01/13