[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range()
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations |
Date: |
Mon, 13 Jan 2014 18:40:22 +0100 |
We were setting a range of bits, so use bitmap_set().
Note: xen has always been wrong, and should have used start instead
of addr from the beginning.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
---
include/exec/memory-internal.h | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index b017c2e..4906cdf 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -81,19 +81,14 @@ static inline void
cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
ram_addr_t length)
{
- ram_addr_t addr, end;
+ unsigned long end, page;
- end = TARGET_PAGE_ALIGN(start + length);
- start &= TARGET_PAGE_MASK;
- for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
- set_bit(addr >> TARGET_PAGE_BITS,
- ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]);
- set_bit(addr >> TARGET_PAGE_BITS,
- ram_list.dirty_memory[DIRTY_MEMORY_VGA]);
- set_bit(addr >> TARGET_PAGE_BITS,
- ram_list.dirty_memory[DIRTY_MEMORY_CODE]);
- }
- xen_modified_memory(addr, length);
+ end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS;
+ page = start >> TARGET_PAGE_BITS;
+ bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION], page, end -
page);
+ bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_VGA], page, end - page);
+ bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_CODE], page, end - page);
+ xen_modified_memory(start, length);
}
static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
--
1.8.4.2
- [Qemu-devel] [PATCH 30/49] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, (continued)
- [Qemu-devel] [PATCH 30/49] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 31/49] memory: unfold cpu_physical_memory_set_dirty() in its only user, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 29/49] memory: split dirty bitmap into three, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 33/49] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 32/49] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 35/49] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 34/49] memory: cpu_physical_memory_get_dirty() is used as returning a bool, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 36/49] memory: use find_next_bit() to find dirty bits, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 38/49] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 39/49] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations,
Juan Quintela <=
- [Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 42/49] memory: split cpu_physical_memory_* functions to its own include, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 43/49] memory: unfold memory_region_test_and_clear(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 40/49] memory: make cpu_physical_memory_reset_dirty() take a length parameter, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 44/49] kvm: use directly cpu_physical_memory_* api for tracking dirty pages, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 45/49] kvm: refactor start address calculation, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 46/49] memory: move bitmap synchronization to its own function, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 48/49] ram: split function that synchronizes a range, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 49/49] migration: synchronize memory bitmap 64bits at a time, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 47/49] memory: syncronize kvm bitmap using bitmaps operations, Juan Quintela, 2014/01/13