[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value |
|
Date: |
Tue, 14 Jan 2014 09:34:38 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> Propagate the error return value from get_indirect().
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/virtio/dataplane/vring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c
> index 250d45e..665a1ff 100644
> --- a/hw/virtio/dataplane/vring.c
> +++ b/hw/virtio/dataplane/vring.c
> @@ -376,7 +376,7 @@ int vring_pop(VirtIODevice *vdev, Vring *vring,
> barrier();
>
> if (desc.flags & VRING_DESC_F_INDIRECT) {
> - int ret = get_indirect(vring, elem, &desc);
> + ret = get_indirect(vring, elem, &desc);
> if (ret < 0) {
> goto out;
> }
Broken in commit 4d684832. Could be mentioned in commit message.
Reviewed-by: Markus Armbruster <address@hidden>