qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading
Date: Tue, 14 Jan 2014 06:47:26 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/13/2014 07:06 PM, Fam Zheng wrote:
> On Mon, 01/13 14:15, Richard Henderson wrote:
>> On 01/13/2014 08:59 AM, Paolo Bonzini wrote:
>>> +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
>>
>> I really really don't like random numbers that make for non-repeatable 
>> builds.
>>  It's a quality-assurance nightmare.
> 
> Can you elaborate this, please?

Build systems like we use at Red Hat want to be able to produce bit-for-bit
identical binaries when given the exact same input.  Using random numbers
during the build process prevents that.

>> and perhaps a file containing that hash created by scripts/make-release.
> 
> What if the source code is not in a git tree, for example a tarball?

You just quoted my answer to that.

Alternately, take a page from gcc and produce a number from a hash of the
relevant object file(s).


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]