[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading |
Date: |
Tue, 14 Jan 2014 06:47:26 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/13/2014 07:06 PM, Fam Zheng wrote:
> On Mon, 01/13 14:15, Richard Henderson wrote:
>> On 01/13/2014 08:59 AM, Paolo Bonzini wrote:
>>> +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
>>
>> I really really don't like random numbers that make for non-repeatable
>> builds.
>> It's a quality-assurance nightmare.
>
> Can you elaborate this, please?
Build systems like we use at Red Hat want to be able to produce bit-for-bit
identical binaries when given the exact same input. Using random numbers
during the build process prevents that.
>> and perhaps a file containing that hash created by scripts/make-release.
>
> What if the source code is not in a git tree, for example a tarball?
You just quoted my answer to that.
Alternately, take a page from gcc and produce a number from a hash of the
relevant object file(s).
r~
- [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic, (continued)
- [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic, Paolo Bonzini, 2014/01/13
- [Qemu-devel] [PATCH v15 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO, Paolo Bonzini, 2014/01/13
- [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Richard Henderson, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Fam Zheng, 2014/01/13
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Peter Maydell, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Paolo Bonzini, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Richard Henderson, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Daniel P. Berrange, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Daniel P. Berrange, 2014/01/14
- Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading, Fam Zheng, 2014/01/15
[Qemu-devel] [PATCH v15 7/9] Makefile: install modules with "make install", Paolo Bonzini, 2014/01/13
[Qemu-devel] [PATCH v15 9/9] block: convert block drivers linked with libs to modules, Paolo Bonzini, 2014/01/13
[Qemu-devel] [PATCH v15 8/9] .gitignore: ignore module related files (dll, so, mo), Paolo Bonzini, 2014/01/13