qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv6 6/6] qemu-iotests: blacklist test 020 for NFS


From: Peter Lieven
Subject: Re: [Qemu-devel] [PATCHv6 6/6] qemu-iotests: blacklist test 020 for NFS protocol
Date: Wed, 15 Jan 2014 08:02:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 15.01.2014 07:27, Fam Zheng wrote:
On Mon, 01/13 11:21, Peter Lieven wrote:
reopening is currently not supported.

Signed-off-by: Peter Lieven <address@hidden>
---
  tests/qemu-iotests/020 |    5 +++++
  1 file changed, 5 insertions(+)

diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020
index a42f32f..f8a849c 100755
--- a/tests/qemu-iotests/020
+++ b/tests/qemu-iotests/020
@@ -46,6 +46,11 @@ _supported_fmt qcow qcow2 vmdk qed
  _supported_proto file
  _supported_os Linux
+# NFS does not support bdrv_reopen_prepare thus qemu-img commit fails.
+if [ "$IMGPROTO" = "nfs" ]; then
+    _notrun "image protocol $IMGPROTO does not support bdrv_commit"
+fi
+
Doesn't "_supported_proto file" above already skip this case?

Fam
You are right, the proto should be generic and just NFS should be blacklisted.

Peter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]