qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/2] spapr: fix H_SET_MODE


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2 0/2] spapr: fix H_SET_MODE
Date: Tue, 21 Jan 2014 13:25:49 +0100

On 21.01.2014, at 11:05, Alexey Kardashevskiy <address@hidden> wrote:

> This is v2 of "spapr: reset @kvm_vcpu_dirty before starting CPU"

Looks good to me :).

> Does it make much sense to split "spapr-hcall: fix H_SET_MODE"?

I don't understand? You mean split into subfunctions by resource? Yes, probably.

> Please comment. Thanks!

Please split patch 2/2 into multiple separate ones isolated to their actual 
function changes (at least endian, trans_mode) for easier bisectability and to 
enable people to cherry-pick one but not the other.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]