[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 9/9] kvm: always update the MPX model specific re
From: |
Liu, Jinsong |
Subject: |
Re: [Qemu-devel] [PULL 9/9] kvm: always update the MPX model specific register |
Date: |
Wed, 22 Jan 2014 04:48:16 +0000 |
Yes, I ignore this point. Thanks!
Jinsong
Paolo Bonzini wrote:
> The original patch from Liu Jinsong restricted them to reset or full
> state updates, but that's unnecessary (and wrong) since the BNDCFGS
> MSR has no side effects.
>
> Cc: Liu Jinsong <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-i386/kvm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 221c8a0..d34981f 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1161,6 +1161,9 @@ static int kvm_put_msrs(X86CPU *cpu, int level)
> kvm_msr_entry_set(&msrs[n++], MSR_IA32_MISC_ENABLE,
> env->msr_ia32_misc_enable);
> }
> + if (has_msr_bndcfgs) {
> + kvm_msr_entry_set(&msrs[n++], MSR_IA32_BNDCFGS,
> env->msr_bndcfgs); + }
> #ifdef TARGET_X86_64
> if (lm_capable_kernel) {
> kvm_msr_entry_set(&msrs[n++], MSR_CSTAR, env->cstar);
> @@ -1224,9 +1227,6 @@ static int kvm_put_msrs(X86CPU *cpu, int level)
> if (cpu->hyperv_vapic) {
> kvm_msr_entry_set(&msrs[n++],
> HV_X64_MSR_APIC_ASSIST_PAGE, 0); }
> - if (has_msr_bndcfgs) {
> - kvm_msr_entry_set(&msrs[n++], MSR_IA32_BNDCFGS,
> env->msr_bndcfgs);
> - }
>
> /* Note: MSR_IA32_FEATURE_CONTROL is written separately, see
> * kvm_put_msr_feature_control. */
- [Qemu-devel] [PULL 0/8] KVM uq/master changes for 2014-01-20, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 1/9] target-i386: Intel MPX, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 4/9] roms: Flush icache when writing roms to guest memory, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 2/9] target-i386: do not special case TSC writeback, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 3/9] target-i386: clear guest TSC on reset, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 7/9] KVM: Retry KVM_CREATE_VM on EINTR, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 5/9] kvm: x86: Separately write feature control MSR on reset, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 8/9] KVM: fix addr type for KVM_IOEVENTFD, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 6/9] mempath prefault: fix off-by-one error, Paolo Bonzini, 2014/01/20
- [Qemu-devel] [PULL 9/9] kvm: always update the MPX model specific register, Paolo Bonzini, 2014/01/20
- Re: [Qemu-devel] [PULL 9/9] kvm: always update the MPX model specific register,
Liu, Jinsong <=
- Re: [Qemu-devel] [PULL 0/8] KVM uq/master changes for 2014-01-20, Paolo Bonzini, 2014/01/20