Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: add test for qcow2 preallocation with different cluster sizes

[Hu Tao]

On Wed, Jan 22, 2014 at 11:02:09AM +0100, Kevin Wolf wrote:
> Am 22.01.2014 um 07:57 hat Hu Tao geschrieben:
> > Signed-off-by: Hu Tao <address@hidden>
> > ---
> > 
> > Note: the current largest test case number is 074, but Kevin suggested 
> > picking
> > 079 as there are in-flight patches taken lower numbers.
> > 
> >  tests/qemu-iotests/079     | 69 
> > ++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/qemu-iotests/079.out | 32 +++++++++++++++++++++
> >  tests/qemu-iotests/group   |  1 +
> >  3 files changed, 102 insertions(+)
> >  create mode 100755 tests/qemu-iotests/079
> >  create mode 100644 tests/qemu-iotests/079.out
> > 
> > diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079
> > new file mode 100755
> > index 0000000..5df045b
> > --- /dev/null
> > +++ b/tests/qemu-iotests/079
> > @@ -0,0 +1,69 @@
> > +#!/bin/bash
> > +#
> > +# Test qcow2 preallocation with different cluster_sizes
> > +#
> > +# Copyright (C) 2014 Fujitsu.
> > +#
> > +# This program is free software; you can redistribute it and/or modify
> > +# it under the terms of the GNU General Public License as published by
> > +# the Free Software Foundation; either version 2 of the License, or
> > +# (at your option) any later version.
> > +#
> > +# This program is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> > +#
> > +
> > +# creator
> > address@hidden
> > +
> > +seq=`basename $0`
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1   # failure is the default!
> > +
> > +_cleanup()
> > +{
> > +   _cleanup_test_img
> > +}
> > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > +
> > +# get standard environment, filters and checks
> > +. ./common.rc
> > +. ./common.filter
> > +
> > +_supported_fmt qcow2
> > +_supported_proto file
> > +_supported_os Linux
> > +
> > +function filter_test_dir()
> > +{
> > +    sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \
> > +        -e "s#$TEST_DIR#TEST_DIR#g"
> > +}
> 
> Can't you use _filter_testdir() from common.filter?

Yes, it works. Thanks!